feat(crypto): Add support for encrypted state events to matrix-sdk-crypto
#5539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #5539 will not alter performanceComparing Summary
|
kaylendog
requested review from
bnjbvr,
andybalaam and
richvdh
and removed request for
a team and
bnjbvr
richvdh
requested changes
Aug 15, 2025
andybalaam
approved these changes
Aug 18, 2025
kaylendog
force-pushed
the
kaylendog/msc3414/crypto
branch
from
17818dd to
ec54819
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5539 +/- ##
=======================================
Coverage 88.59% 88.59%
=======================================
Files 340 340
Lines 93836 93847 +11
Branches 93836 93847 +11
=======================================
+ Hits 83133 83143 +10
Misses 6572 6572
- Partials 4131 4132 +1 ☔ View full report in Codecov by Sentry. |
richvdh
reviewed
Aug 18, 2025
kaylendog
requested review from
richvdh and
andybalaam
and removed request for
andybalaam
This commit also refactors out what would be common code between ::encrypt and ::encrypt_state to a helper ::encrypt_inner. Signed-off-by: Skye Elliot <[email protected]>
Signed-off-by: Skye Elliot <[email protected]>
Signed-off-by: Skye Elliot <[email protected]>
Modifies `OlmMachine::decrypt_room_event_inner` to call a new method `OlmMachine::verify_packed_state_key` which, if the event is a state event, verifies that the original event's state key, when unpacked, matches the state key and event type in the decrypted event content. Introduces MegolmError::StateKeyVerificationFailed and UnableToDecryptReason::StateKeyVerificationFailed which are thrown when the verification fails. Signed-off-by: Skye Elliot <[email protected]>
kaylendog
force-pushed
the
kaylendog/msc3414/crypto
branch
from
9ae4a3a to
84ebbd9
Compare
richvdh
approved these changes
Aug 19, 2025
Signed-off-by: Skye Elliot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #5511, #5512 and #5523.
OutboundGroupSession::encrypt_state.GroupSessionManager::encrypt_stateand a private helper function::encrypt_inner.OlmMachine::encrypt_state_eventand::encrypt_state_event_raw.OlmMachine::decrypt_room_event_inner.